Simplify jflex configuration #3431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
anuraaga
commented
Jun 29, 2021
| java { | ||
| // gradle-jflex-plugin has a bug in that it always looks for the last srcDir in this source | ||
| // set to generate into. By default it would be the src/main directory itself. | ||
| srcDir("${buildDir}/generated/sources/jflex") |
There was a problem hiding this comment.
I went ahead and changed the directory a bit to match what gradle-jflex-plugin wanted to use as a default
Even though that code can basically never use that default as the java sourceset will always have a srcDir, the src/main dir.
laurit
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JFlex plugin automatically sets itself up. The problem was that it requires files to have extension
.jflexhttps://github.com/jprante/gradle-plugin-jflex/blob/master/src/main/groovy/org/xbib/gradle/plugin/JFlexPlugin.groovy#L42
https://github.com/jprante/gradle-plugin-jflex/blob/master/src/main/groovy/org/xbib/gradle/plugin/JFlexPlugin.groovy#L72