Migrate muzzle plugin to kotlin script. #3388
Conversation
anuraaga
requested review from
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
|
|
||
| val muzzleConfig = extensions.create<MuzzleExtension>("muzzle") | ||
|
|
||
| val muzzleTooling by configurations.creating { |
There was a problem hiding this comment.
Creating the configurations in the plugin instead of the project like before as plugins normally do. I haven't quite been able to reason out the difference between these configurations yet (intuitively I'd expect us to only need one classpath when muzzling) but have reproduced the split for now.
There was a problem hiding this comment.
I think one of them (muzzleTooling) is supposed to be used as the agent classpath source (to be able to load InstrumentationModule), the other (muzzleBootstrap) should be a base for the "instrumented application" classpath - add the library jar for a given version to our bootstrap classes and pass it to the check method.
There was a problem hiding this comment.
Ah thanks that makes sense!
anuraaga
force-pushed
the
muzzle-kotlinscript
branch
from
a15041b
to
40ce9c6
Compare
| val userUrls = objects.fileCollection() | ||
| logger.info("Creating task classpath") | ||
| userUrls.from(muzzleTaskConfiguration.resolvedConfiguration.files) | ||
| return classpathLoader(userUrls.plus(muzzleTooling), ClassLoader.getPlatformClassLoader()) |
There was a problem hiding this comment.
Shouldn't that be the bootstrap conf?
| return classpathLoader(userUrls.plus(muzzleTooling), ClassLoader.getPlatformClassLoader()) | |
| return classpathLoader(userUrls.plus(muzzleBootstrap), ClassLoader.getPlatformClassLoader()) |
There was a problem hiding this comment.
Oops - guess it still passed since bootstrap gets included transitively
…ry-java-instrumentation into muzzle-kotlinscript
No description provided.