Use SDK Autoconfigure module #2077
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| package io.opentelemetry.javaagent.tooling; | ||
|
|
||
| import com.google.auto.service.AutoService; | ||
| import io.opentelemetry.api.metrics.GlobalMetricsProvider; | ||
| import io.opentelemetry.instrumentation.api.config.Config; | ||
| import io.opentelemetry.javaagent.spi.exporter.MetricExporterFactory; | ||
| import io.opentelemetry.javaagent.spi.exporter.SpanExporterFactory; | ||
| import io.opentelemetry.sdk.autoconfigure.spi.SdkTracerProviderConfigurer; | ||
| import io.opentelemetry.sdk.metrics.SdkMeterProvider; | ||
| import io.opentelemetry.sdk.metrics.export.IntervalMetricReader; | ||
| import io.opentelemetry.sdk.metrics.export.MetricExporter; | ||
| import io.opentelemetry.sdk.trace.SdkTracerProviderBuilder; | ||
| import io.opentelemetry.sdk.trace.SpanProcessor; | ||
| import io.opentelemetry.sdk.trace.export.BatchSpanProcessor; | ||
| import io.opentelemetry.sdk.trace.export.SpanExporter; | ||
| import java.io.File; | ||
| import java.net.MalformedURLException; | ||
| import java.net.URL; | ||
| import java.util.Collections; | ||
| import java.util.Iterator; | ||
| import java.util.Properties; | ||
| import java.util.ServiceLoader; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| @AutoService(SdkTracerProviderConfigurer.class) | ||
| public class AgentTracerProviderConfigurer implements SdkTracerProviderConfigurer { | ||
| private static final Logger log = LoggerFactory.getLogger(AgentTracerProviderConfigurer.class); | ||
|
|
||
| static final String EXPORTER_JAR_CONFIG = "otel.exporter.jar"; | ||
|
|
||
| @Override | ||
| public void configure(SdkTracerProviderBuilder sdkTracerProviderBuilder) { | ||
| if (!Config.get().getBooleanProperty(OpenTelemetryInstaller.JAVAAGENT_ENABLED_CONFIG, true)) { | ||
| return; | ||
| } | ||
|
|
||
| // Register additional thread details logging span processor | ||
| sdkTracerProviderBuilder.addSpanProcessor(new AddThreadDetailsSpanProcessor()); | ||
|
|
||
| maybeConfigureExporterJar(sdkTracerProviderBuilder); | ||
| } | ||
|
|
||
| private static void maybeConfigureExporterJar(SdkTracerProviderBuilder sdkTracerProviderBuilder) { | ||
| String exporterJar = Config.get().getProperty(EXPORTER_JAR_CONFIG); | ||
| if (exporterJar == null) { | ||
| return; | ||
| } | ||
| Properties config = Config.get().asJavaProperties(); | ||
| installExportersFromJar(exporterJar, config, sdkTracerProviderBuilder); | ||
| } | ||
|
|
||
| private static synchronized void installExportersFromJar( | ||
| String exporterJar, Properties config, SdkTracerProviderBuilder builder) { | ||
| URL url; | ||
| try { | ||
| url = new File(exporterJar).toURI().toURL(); | ||
| } catch (MalformedURLException e) { | ||
| log.warn("Filename could not be parsed: " + exporterJar + ". Exporter is not installed"); | ||
| log.warn("No valid exporter found. Tracing will run but spans are dropped"); | ||
| return; | ||
| } | ||
| ExporterClassLoader exporterLoader = | ||
|
There was a problem hiding this comment. Going to add an exporter SPI to SDK since it seems to make sense. But I wonder if it would be possible to use from agent given we load external JARs into separate classloader like this. Any idea? There was a problem hiding this comment. ya, not sure how to make it play nice with the autoconfigure env vars |
||
| new ExporterClassLoader(url, OpenTelemetryInstaller.class.getClassLoader()); | ||
|
|
||
| SpanExporterFactory spanExporterFactory = | ||
| getExporterFactory(SpanExporterFactory.class, exporterLoader); | ||
|
|
||
| if (spanExporterFactory != null) { | ||
| installExporter(spanExporterFactory, config, builder); | ||
| } else { | ||
| log.warn("No span exporter found in {}", exporterJar); | ||
| log.warn("No valid exporter found. Tracing will run but spans are dropped"); | ||
| } | ||
|
|
||
| MetricExporterFactory metricExporterFactory = | ||
| getExporterFactory(MetricExporterFactory.class, exporterLoader); | ||
| if (metricExporterFactory != null) { | ||
| installExporter(metricExporterFactory, config); | ||
| } | ||
| } | ||
|
|
||
| private static <F> F getExporterFactory(Class<F> service, ExporterClassLoader exporterLoader) { | ||
| ServiceLoader<F> serviceLoader = ServiceLoader.load(service, exporterLoader); | ||
| Iterator<F> i = serviceLoader.iterator(); | ||
| if (i.hasNext()) { | ||
| F factory = i.next(); | ||
| if (i.hasNext()) { | ||
| log.warn( | ||
| "Exporter JAR defines more than one {}. Only the first one found will be used", | ||
| service.getName()); | ||
| } | ||
| return factory; | ||
| } | ||
| return null; | ||
| } | ||
|
|
||
| private static void installExporter( | ||
| SpanExporterFactory spanExporterFactory, | ||
| Properties config, | ||
| SdkTracerProviderBuilder builder) { | ||
| SpanExporter spanExporter = spanExporterFactory.fromConfig(config); | ||
| SpanProcessor spanProcessor = BatchSpanProcessor.builder(spanExporter).build(); | ||
| builder.addSpanProcessor(spanProcessor); | ||
| log.info("Installed span exporter: " + spanExporter.getClass().getName()); | ||
| } | ||
|
|
||
| private static void installExporter( | ||
| MetricExporterFactory metricExporterFactory, Properties config) { | ||
| MetricExporter metricExporter = metricExporterFactory.fromConfig(config); | ||
| IntervalMetricReader.builder() | ||
| .readProperties(config) | ||
| .setMetricExporter(metricExporter) | ||
| .setMetricProducers(Collections.singleton((SdkMeterProvider) GlobalMetricsProvider.get())) | ||
| .build(); | ||
| log.info("Installed metric exporter: " + metricExporter.getClass().getName()); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move somewhere closer to all other exporters? Or sort alphabetically?