Simplify Apache HttpAsyncClient instrumentation #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek and
tylerbenson
as code owners
iNikem
approved these changes
Dec 14, 2020
anuraaga
approved these changes
Dec 14, 2020
bhautikpip
pushed a commit
to bhautikpip/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 18, 2020
* Simplify Apache HttpAsyncClient instrumentation * Bump baseline version to 4.1 * Remove all the Intellij auto-formatting of README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surprisingly, this is not part of #1840.
This PR removes a hack that only existing for Apache HttpAsyncClient 4.0 and 4.0.1, which are over 5 years old.
Plus the hack was extra hacky and only supported W3C trace propagation headers.
Bumped module baseline from 4.0 to 4.1 to reflect that is really our min supported version.