Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try using low Gradle priority instead of capping workers #1538

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

anuraaga
Copy link
Contributor

@anuraaga anuraaga commented Nov 2, 2020

Gradle team recommended trying this setting - can anyone else check if it helps with their builds? Even so, I'm worried it will still be too much for CI but let's see what happens. For me locally, build seems to be going reasonably fast without bogging down computer.

@anuraaga
Copy link
Contributor Author

anuraaga commented Nov 2, 2020

Since this PR build can all come from cache, not representative of whether this flag negatively affects the CI 😿

@iNikem
Copy link
Contributor

iNikem commented Nov 2, 2020

Do we have performance-related problems with CI lately? I don't think so.

I am trying to better understand and separate two problems: local builds and CI builds. If we have problems with local builds only, they all are fixable by ~/.gradle/gradle.properties and proper documentation. I think current configuration is adequate for the CI

@anuraaga
Copy link
Contributor Author

anuraaga commented Nov 2, 2020

The current default is probably good for CI - but indeed if I don't set the workers higher the build feels very slow locally. max-workers=4 works well for me but this priority setting also worked well I think. But it's not a scientific result :)

Since we control CI, we can set the properties there to anything we want so I think it could be good to have this file to default to the best local build experience. max-workers=2 isn't for me and I think priority=low might be a reasonable, hw-agnostic default. But need more testers.

If this makes sense I'll go ahead and tweak the CI files to restore normal priority + max-workers=2 there to make sure that doesn't degrade. Let me know how it goes

@iNikem
Copy link
Contributor

iNikem commented Nov 2, 2020

I will try.

Gradle team recommended trying this setting

Can you point me to this?

@iNikem
Copy link
Contributor

iNikem commented Nov 2, 2020

I am not sure if this new setting is better or worse than the old one, but this new one works fine for me on two different Macs.

@trask
Copy link
Member

trask commented Nov 3, 2020

wow, that setting is almost magical on my machine 😲

100% cpu utilization, but machine is still responsive, unlike before

let's merge and give it a longer term spin

image

@trask trask merged commit 4e50e64 into master Nov 3, 2020
@trask trask deleted the anuraaga-patch-2 branch November 3, 2020 04:50
@anuraaga
Copy link
Contributor Author

anuraaga commented Nov 5, 2020

@iNikem Sorry for late reply, Gradle team response is at gradle/gradle#14224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants