Add org.gradle.workers.max to gradle.properties #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
reviewed
Oct 10, 2020
| @@ -1,5 +1,9 @@ | |||
| org.gradle.parallel=true | |||
| org.gradle.caching=true | |||
|
|
|||
| # limiting the number of parallel workers helps to keep your machine responsive during builds | |||
| # see https://github.com/gradle/gradle/issues/14224 | |||
| org.gradle.workers.max=2 | |||
There was a problem hiding this comment.
Just for reference, I have 4 cores with hyperthreading, and max-workers of 4 works well since it ends up with 8 which is all my threads. This will end up with 6 workers if I'm not mistaken (build always adds 4 extra workers) - wonder if it works on a 4-core without hyperthreading machine.
iNikem
approved these changes
Oct 10, 2020
|
Merging, but very open to revisit (further restrict, e.g. remove parallel completely) if we find contributors continue to run into this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #740