Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate github action renovate PRs #11829

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

trask
Copy link
Member

@trask trask commented Jul 15, 2024

Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but perhaps @secustor can give a second opinion?

Copy link

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it maybe helpful to consider the downsides of grouping large numbers of dependencies.
https://docs.renovatebot.com/noise-reduction/#be-smart-about-grouping-dependencies

@jpkrohling
Copy link
Member

I agree, in this case it makes sense though: GitHub Actions have a lower risk, and it's quite clear when they break.

@laurit
Copy link
Contributor

laurit commented Jul 22, 2024

Lately renovate created some PRs where version was update to an older version, batching the updates would make this harder to spot.

@secustor
Copy link

Lately renovate created some PRs where version was update to an older version, batching the updates would make this harder to spot.

There has been an issue which we couldn't reproduce so far, but users report that a guardrail against that works. renovatebot/renovate#29919

@trask
Copy link
Member Author

trask commented Jul 22, 2024

I'm currently testing this in my fork with schedule:daily to see if it works...

looks like it's working: trask#3

@trask
Copy link
Member Author

trask commented Jul 23, 2024

let's give it a try...

@trask trask merged commit 460bd3f into open-telemetry:main Jul 23, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants