jetty9 http client: don't implement Response.CompleteListener

[laurit]

The onComplete method isn't really called because we never register the complete listener in

opentelemetry-java-instrumentation/instrumentation/jetty-httpclient/jetty-httpclient-9.2/library/src/main/java/io/opentelemetry/instrumentation/jetty/httpclient/v9_2/internal/JettyHttpClient9TracingInterceptor.java

Lines 83 to 87 in 55e723e

	jettyRequest
	.onRequestBegin(this)
	.onRequestFailure(this)
	.onResponseFailure(this)
	.onResponseSuccess(this);

Having the success and failure listeners should be enough.

[heyams]

Suggested change

	if (this.context != null) {
	instrumenter.end(this.context, response.getRequest(), response, null);
	}
	if (this.context != null) {
	instrumenter.end(this.context, response.getRequest(), response, null);
	} else {
	logger.fine("onSuccess - could not find an otel context");
	}

[laurit]

Is this log line really useful? Looking at the code currently context being null doesn't really indicate that anything is wrong. Imo it would be better to refactor this so that the listener isn't added at all when span isn't started.

[heyams]

Imo it would be better to refactor this so that the listener isn't added at all when span isn't started.
👍