Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky finagle test #11441

Merged
merged 1 commit into from
May 24, 2024
Merged

Fix flaky finagle test #11441

merged 1 commit into from
May 24, 2024

Conversation

laurit
Copy link
Contributor

@laurit laurit commented May 23, 2024

Resolves #11437
Second try at resolving finagle http client test flakiness.

@laurit laurit requested a review from a team as a code owner May 23, 2024 13:57
jeanbisutti
jeanbisutti reviewed May 23, 2024
View reviewed changes
Copy link
Member

@jeanbisutti jeanbisutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation is updated. So, was the implementation flaky?

@laurit
Copy link
Contributor Author

laurit commented May 24, 2024

The implementation is updated. So, was the implementation flaky?

Correct. There was a context propagation issue where http client span got placed under wrong parent span.

@laurit laurit merged commit c9cbd8a into open-telemetry:main May 24, 2024
51 of 53 checks passed
@laurit laurit deleted the finagle-flaky2 branch May 24, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanbisutti jeanbisutti jeanbisutti left review comments

@trask trask trask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workflow failed: Build (daily --no-build-cache) (#795)
3 participants
@laurit @trask @jeanbisutti