Update the OpenTelemetry SDK version to 1.38.0 #11335
Conversation
github-actions
bot
added
the
test native
| .hasAttributesSatisfying( | ||
| equalTo(stringKey("test"), "test")))))); | ||
|
|
||
| // sleep exporter interval |
There was a problem hiding this comment.
Could you please explain the reason of this sleep and the following one?
There was a problem hiding this comment.
This appears to be a standard pattern that is used in these tests. It was already present in the original version of this test (this test is a slightly modified copy of the same test in v1_37 which is a copy from another version). My understanding is that the first sleep is there to ensure that metric data arrives before clearData is called, but as there is already a call to waitAndAssertMetrics that also waits for metrics to arrive (actually it waits for assertion to pass, but here assertion requires metrics) I don't think it is really necessary. The second sleep after clearData should ensure that if there is new metrics are produced they have time to arrive. I think this is necessary because the following waitAndAssertMetrics asserts that there are no metrics and this could pass if we don't wait until metrics have had time to arrive (assuming that there is a bug and there unexpectedly are metrics).
Changing these is out of the scope for this PR.
| import org.junit.jupiter.api.TestInfo; | ||
| import org.junit.jupiter.api.extension.RegisterExtension; | ||
|
|
||
| class MeterTest { |
There was a problem hiding this comment.
what do you think of extending an AbstractMeterTest so we can get coverage of all the normal metrics behavior as well, or do you think it's not really needed?
Co-authored-by: Lauri Tulmin <[email protected]>
Co-authored-by: Lauri Tulmin <[email protected]>
Update the OpenTelemetry SDK version to
1.38.0.