ci: use .java-version #11323
Merged
ci: use .java-version #11323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
commented
May 9, 2024
Comment on lines
+16
to
+21
| - id: read-java | ||
| run: echo "version=$(cat .java-version)" >> "$GITHUB_OUTPUT" | ||
| - uses: graalvm/setup-graalvm@2f25c0caae5b220866f732832d5e3e29ff493338 # v1.2.1.1 | ||
| with: | ||
| version: "latest" | ||
| java-version: "21" | ||
| java-version: "${{ steps.read-java.outputs.version }}" |
There was a problem hiding this comment.
This can be potentially once graalvm/setup-graalvm#95 is done :)
|
why not use |
laurit
approved these changes
May 13, 2024
I've no strong opinion. However, it might be better to done it in a follow-up, once graalvm/setup-graalvm#95 is available. Then, there won't be any need to parse the file regardless. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Revert f6d3b6b to enable the
.java-versionand honour the GitHub actions setup-java by using thejava-version-file, see Java-version-file docs.Why
This should help reduce the maintainability of the GitHub actions by centralising the version to be used in the CI in one place.