Semconv 1.25.0 migration

[SylvainJuge]

The 1.24.0 release of semconv for java brings breaking changes that prevent a simple upgrade PR like #10971 to work as expected.

As there are lots of changes I've split the PR in separate commits:

• 1b46cf5 update to semconv 1.24.0 from fix(deps): update dependency io.opentelemetry.semconv:opentelemetry-semconv to v1.25.0-alpha (main) - autoclosed #10971
• f2d90cf introduce a temporary module to keep compile-time compatibility and minimize code changes
• migrate semconv attributes and remove temporary module (about 1 commit per semconv namespace).

For SemanticAttributes.EXCEPTION_EVENT_NAME I had to inline and duplicate the "exception" value as there isn't any equivalent in the new semantic conventions.

Follow-up questions where input is welcome

• should we keep a copy of the old semconv classes to make migration easier (Semconv 1.25.0 migration #10983 (review)).
  Answer is "YES" and this was done
• if yes, should we keep it here in the agent or in a separate repo/artifact ? (Semconv 1.25.0 migration #10983 (comment))
  Answer is "NO", it remains as part of the "stable" semconv artifact due to the usage of java modules that prevent having classes from a package spread in more than one artifact.

Follow-up tasks once this is merged

• deprecation of in "db.connection_string" semconv 1.25.0 #11069
• deprecation of in "messaging.kafka.destination.partition" semconv 1.25.0 #11070

[SylvainJuge]

[for reviewer] I don't know the reason this class was introduced in the first place, but given all the attributes are now part of semconv, it's probably a good time to use them.

[laurit]

As far as I know this class was temporarily introduced to use attributes that weren't present int the latest semconv jar. It is fine to remove it now.

[SylvainJuge]

[for reviewer] this is one of the cases where the SemanticAttributes.EXCEPTION_EVENT_NAME has no equivalent in the new semconv and I had to inline the value as-is.

[SylvainJuge]

Thanks for working on this. I think we are going to need to preserve the old semconv classes in the agent to avoid breaking extensions that could be using the old semconv classes. We could do this either by copying these semconv classes like you did in the previous version of this PR or by doing some build script magic. This can be done in a separate PR. @trask WDYT?

If every project that depends on semconv java is impacted, then it could make sense to provide such "compatibility layer" directly in https://github.com/open-telemetry/semantic-conventions-java/ as a separate artifact to make migration easier (with of course deprecation warnings), then drop it after a few releases to push migration and avoid having to keep it forever, or we could even include it as part of the semconv-incubating artifact to make it obvious that it won't be there forever without having a separate artifact.

[SylvainJuge]

[for reviewer] I am not sure what is the "right" value to pick here, so I picked the 1.24.0 to match the semconv version.

[trask]

Thanks for working on this.

💯

I think we are going to need to preserve the old semconv classes in the agent to avoid breaking extensions that could be using the old semconv classes. We could do this either by copying these semconv classes like you did in the previous version of this PR or by doing some build script magic. This can be done in a separate PR. @trask WDYT?

I'd support copying the old semconv classes in (seems easiest) and marking them all as deprecated. We can remove the copies in 3.0 when we bump database and RPC semconv.

[SylvainJuge]

Following yesterday sig meeting discussion, I've opened open-telemetry/semantic-conventions-java#62 to include a copy of the old classes and that will likely be included in the upcoming 1.25.0 release of semantic-conventions-java.

So such big-bang migration won't be needed once 1.25.0 is out, but the migration needs to happen anyway and it's already done here, thus I think it's still relevant to review and merge it.

[trask]

just holding off on merging this for the next semconv java 1.25.0 release, so we can avoid breaking any Java agent extensions that were relying on the old classes

[trask]

semconv java 1.25.0 has been released

@SylvainJuge when you have time, can you update to 1.25.0 and resolve conflicts, then we'll merge it!

[SylvainJuge]

Fixing the conflicts was the easy and fun part, bumping semconv to 1.25.0 also brings the following:

• service and exception attributes are now stable, in commits 7984016 and 6839613 respectively
• db.connection_string is now deprecated, I've used @SuppressWarnings as shortcut in 969c239 and opened
  deprecation of in "db.connection_string" semconv 1.25.0 #11069 as follow-up task
• messaging.kafka.destination.partition is now deprecated, I've used @SuppressWarnings as shortcut in 8373832 and opened deprecation of in "messaging.kafka.destination.partition" semconv 1.25.0 #11070 as follow-up task

So with those new additions that should be good to go.