Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid semantic conventions doc url fix #10954

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

xiangtianyu
Copy link
Contributor

@xiangtianyu xiangtianyu commented Mar 26, 2024

semantic conventions doc has moved to new repo or directory, so the old url are invalid, update these doc urls

@xiangtianyu xiangtianyu requested a review from a team as a code owner March 26, 2024 01:36
@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Mar 26, 2024
Copy link
Contributor

@steverao steverao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you only fixed a part of them, maybe you can use the keyword of semantic_conventions to find all relevant problems and fix all this time.
image

@xiangtianyu
Copy link
Contributor Author

It seems you only fixed a part of them, maybe you can use the keyword of semantic_conventions to find all relevant problems and fix all this time. image

The other matches are in changelog or like such url include specific version "https://github.com/open-telemetry/opentelemetry-specification/blob/v1.20.0/specification/trace/semantic_conventions/instrumentation/aws-sdk.md"

@steverao
Copy link
Contributor

It seems you only fixed a part of them, maybe you can use the keyword of semantic_conventions to find all relevant problems and fix all this time. image

The other matches are in changelog or like such url include specific version "https://github.com/open-telemetry/opentelemetry-specification/blob/v1.20.0/specification/trace/semantic_conventions/instrumentation/aws-sdk.md"

It will be better to fix invalid url in changelog instead of ignoring it. After fixing it, we may need to update relevant release note again. cc @open-telemetry/java-instrumentation-approvers

@xiangtianyu
Copy link
Contributor Author

xiangtianyu commented Mar 26, 2024

It seems you only fixed a part of them, maybe you can use the keyword of semantic_conventions to find all relevant problems and fix all this time. image

The other matches are in changelog or like such url include specific version "https://github.com/open-telemetry/opentelemetry-specification/blob/v1.20.0/specification/trace/semantic_conventions/instrumentation/aws-sdk.md"

It will be better to fix invalid url in changelog instead of ignoring it. After fixing it, we may need to update relevant release note again. cc @open-telemetry/java-instrumentation-approvers

We may change these changelog urls to such url include specific version "https://github.com/open-telemetry/opentelemetry-specification/blob/v1.13.0/specification/metrics/semantic_conventions/runtime-environment-metrics.md"? Or to the new repo?

@laurit laurit merged commit 42ba962 into open-telemetry:main Apr 8, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test native This label can be applied to PRs to trigger them to run native tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants