Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename auto exporters module #1022

Merged
merged 12 commits into from
Aug 18, 2020
Merged

Rename auto exporters module #1022

merged 12 commits into from
Aug 18, 2020

Conversation

trask
Copy link
Member

@trask trask commented Aug 17, 2020

This PR does 3 things:

  • Renames auto-exporters parent module to javaagent-exporters
  • Fixes outdated command in CONTRIBUTING.md
  • Updates the archivesBaseName so that jar file names under build/libs match their artifact names

anuraaga
anuraaga approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure, you did check publishToMavenLocal artifacts?

gradle/instrumentation.gradle Show resolved Hide resolved
@trask
Copy link
Member Author

trask commented Aug 17, 2020

Just to make sure, you did check publishToMavenLocal artifacts?

Yup 👍

iNikem
iNikem approved these changes Aug 17, 2020
View reviewed changes
smoke-tests/smoke-tests.gradle Outdated Show resolved Hide resolved
@trask trask merged commit 6a07b17 into open-telemetry:master Aug 18, 2020
@trask trask deleted the rename-auto-exporters-module branch August 18, 2020 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iNikem iNikem iNikem approved these changes

@anuraaga anuraaga anuraaga approved these changes

@jkwatson jkwatson Awaiting requested review from jkwatson

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trask @anuraaga @iNikem