Skip to content

Commit

Permalink
Remove commons-codec (not needed?) (#6249)
Browse files Browse the repository at this point in the history
* remove commons-codec (not needed?)

* add commons-codec back and add note
  • Loading branch information
breedx-splk committed Jul 4, 2022
1 parent f389391 commit 886665a
Showing 1 changed file with 10 additions and 8 deletions.
18 changes: 10 additions & 8 deletions dependencyManagement/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,14 @@ rootProject.extra["otelVersion"] = otelVersion
val groovyVersion = "4.0.2"

// We don't force libraries we instrument to new versions since we compile and test against specific
// old baseline versions
// but we do try to force those libraries' transitive dependencies to new versions where possible
// so that we don't end up with explosion of dependency versions in Intellij, which causes
// Intellij to spend lots of time indexing all of those different dependency versions,
// and makes debugging painful because Intellij has no idea which dependency version's source
// to use when stepping through code.
// old baseline versions but we do try to force those libraries' transitive dependencies to new
// versions where possible so that we don't end up with explosion of dependency versions in
// Intellij, which causes Intellij to spend lots of time indexing all of those different dependency
// versions, and makes debugging painful because Intellij has no idea which dependency version's
// source to use when stepping through code.
//
// Sometimes libraries we instrument do require a specific version of a transitive dependency
// and that can be applied in the specific instrumentation gradle file, e.g.
// Sometimes libraries we instrument do require a specific version of a transitive dependency and
// that can be applied in the specific instrumentation gradle file, e.g.
// configurations.testRuntimeClasspath.resolutionStrategy.force "com.google.guava:guava:19.0"

val DEPENDENCY_BOMS = listOf(
Expand Down Expand Up @@ -78,6 +77,9 @@ val DEPENDENCY_SETS = listOf(
),
)

// See the comment above about why we keep this rather large list.
// There are dependencies included here that appear to have no usages, but are maintained at
// this top level to help consistently satisfy large numbers of transitive dependencies.
val DEPENDENCIES = listOf(
"ch.qos.logback:logback-classic:1.2.11",
"com.github.stefanbirkner:system-lambda:1.2.1",
Expand Down

0 comments on commit 886665a

Please sign in to comment.