[chore] [exporterhelper] Move shutdown error from queue package #9554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9554 +/- ##
==========================================
+ Coverage 90.57% 90.58% +0.01%
==========================================
Files 347 347
Lines 18244 18247 +3
==========================================
+ Hits 16524 16529 +5
+ Misses 1390 1388 -2
Partials 330 330 ☔ View full report in Codecov by Sentry. |
358007a
to
4e218d0
Compare
jmacd
approved these changes
Feb 13, 2024
4e218d0
to
0e958f2
Compare
codeboten
approved these changes
Feb 13, 2024
|
@dmitryax please resolve the conflict |
The error is created by the retry sender and used by the queue sender. It doesn't belong to queue package
0e958f2
to
3dea08d
Compare
|
@codeboten. done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error is created by the retry sender and used by the queue sender. It doesn't belong to queue package