[confignet] Rename NetAddr and TCPAddr to follow conventions #9529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
force-pushed
the
mx-psi/confignet
branch
from
412e1ff
to
f54a4c9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9529 +/- ##
=======================================
Coverage 90.41% 90.41%
=======================================
Files 347 347
Lines 18184 18184
=======================================
Hits 16441 16441
Misses 1412 1412
Partials 331 331 ☔ View full report in Codecov by Sentry. |
bogdandrutu
approved these changes
Feb 8, 2024
|
@bogdandrutu I reduced the scope of this PR to just have the renaming of the types and not of any fields using them. I will merge on Wednesday unless you (or anybody else) raises concerns about this before then |
codeboten
approved these changes
Feb 12, 2024
TylerHelmuth
approved these changes
Feb 12, 2024
bogdandrutu
approved these changes
Feb 13, 2024
github-actions
bot
modified the milestones:
`go.opentelemetry.io/collector/config/confignet` 1.0,
next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Rename types in
confignetto adapt to conventions (avoid stuttering and end inConfig)Link to tracking Issue: Updates #9509