Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configcompression] Rename CompressionType to Type #9416

Merged

Conversation

TylerHelmuth
Copy link
Member

Description:
If we choose to go with the rename.

Link to tracking Issue:
Related to #9388

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa1b241) 90.44% compared to head (2ecc74d) 90.42%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9416      +/-   ##
==========================================
- Coverage   90.44%   90.42%   -0.02%     
==========================================
  Files         346      346              
  Lines       18106    18106              
==========================================
- Hits        16376    16373       -3     
- Misses       1399     1401       +2     
- Partials      331      332       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

config/configcompression/compressiontype.go Outdated Show resolved Hide resolved
config/configcompression/compressiontype.go Show resolved Hide resolved
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TypeDeflate Type = "deflate"
TypeSnappy Type = "snappy"
TypeZstd Type = "zstd"
typeNone Type = "none"
Copy link
Member

@bogdandrutu bogdandrutu Feb 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should "none" be a valid type? By valid I mean public to be used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the original PR's conversation there wasn't a public use case for none: #4651 (comment). Until the last 2 weeks there haven't been any material changes to the package so I'm guessing that there still isn't any public use case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something we could do after 1.0, I think we can keep it as is and expose in the future if we have a specific need

none,
empty:
func (ct *Type) UnmarshalText(in []byte) error {
switch typ := Type(in); typ {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Sorry, but my mind goes crazy when I see a switch used like an if :)) Can we fix this probably in a separate PR :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you objecting to typ := Type(in); typ or the switch statement in general?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I don't like switch statements with only 2 branches, the are if's no? :)) But is a nit and not a blocker for sure.

TypeDeflate Type = "deflate"
TypeSnappy Type = "snappy"
TypeZstd Type = "zstd"
typeNone Type = "none"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something we could do after 1.0, I think we can keep it as is and expose in the future if we have a specific need

@mx-psi
Copy link
Member

mx-psi commented Feb 2, 2024

I think we can merge this on Monday EU morning to get it to next week's release, unless there are objections by then (all pending conversations don't affect public API and can be solved on separate PRs)

none,
empty:
func (ct *Type) UnmarshalText(in []byte) error {
switch typ := Type(in); typ {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I don't like switch statements with only 2 branches, the are if's no? :)) But is a nit and not a blocker for sure.

@bogdandrutu
Copy link
Member

Please rebase

@mx-psi
Copy link
Member

mx-psi commented Feb 5, 2024

Filed #9458 and #9459 as follow ups. Merging...

@mx-psi mx-psi merged commit f5a7315 into open-telemetry:main Feb 5, 2024
43 of 46 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 5, 2024
@TylerHelmuth TylerHelmuth deleted the configcompression-rename-enum branch February 12, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants