Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdatagen] update crosslink to avoid replace statements #9310

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

codeboten
Copy link
Contributor

Fixes #9281

@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 17, 2024
@codeboten codeboten requested a review from a team as a code owner January 17, 2024 23:03
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with that fix, however, it means mdatagen will continue to import packages from this repository. Will this matter to mdatagen? Will it be updated separately?

@codeboten
Copy link
Contributor Author

I am ok with that fix, however, it means mdatagen will continue to import packages from this repository. Will this matter to mdatagen? Will it be updated separately?

With this change, mdatagen will only used released versions of the packages from this repo. I don't know what a workaround this is if we want mdatagen to be installed via go install

Signed-off-by: Alex Boten <[email protected]>
@codeboten
Copy link
Contributor Author

@atoulme i suppose we could still use unreleased versions of the packages as long as they're explicitly stated in the go.mod file, without replace statements 🤷🏻

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (51b0e4d) 90.35% compared to head (eddc4f2) 90.34%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9310      +/-   ##
==========================================
- Coverage   90.35%   90.34%   -0.01%     
==========================================
  Files         340      340              
  Lines       17968    17987      +19     
==========================================
+ Hits        16235    16251      +16     
- Misses       1410     1412       +2     
- Partials      323      324       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TylerHelmuth
Copy link
Member

If we make a change to mdatagen, like say adding a new field to the readme headers, does this change prevent us from testing that change on one of core's components until after the release?

@codeboten
Copy link
Contributor Author

If we make a change to mdatagen, like say adding a new field to the readme headers, does this change prevent us from testing that change on one of core's components until after the release?

It does not. Its just that if a change happens in one of the core components, it wont be automatically tested by mdatagen

@bogdandrutu bogdandrutu merged commit 9bb794b into open-telemetry:main Jan 22, 2024
32 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 22, 2024
@codeboten codeboten deleted the codeboten/update-crosslink branch January 22, 2024 21:47
TylerHelmuth pushed a commit to TylerHelmuth/opentelemetry-collector that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go install fails for mdatagen
4 participants