[pkg/sharedcomponent] new package pkg/sharedcomponent

[atoulme]

Description:
Expose the internal package internal/sharedcomponent as pkg/sharedcomponent

Link to tracking Issue:
Fixes #4266

Testing:
N/A

Documentation:
N/A

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f0c9e1) 91.41% compared to head (5645dc5) 91.41%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9151   +/-   ##
=======================================
  Coverage   91.41%   91.41%           
=======================================
  Files         320      320           
  Lines       17187    17187           
=======================================
  Hits        15711    15711           
  Misses       1173     1173           
  Partials      303      303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bogdandrutu]

Before doing this, I would consider better to polish this code and move it to component/componentshared or component/sharedcomponent.

But would like to do a pass on the API (consistency with other APIs that we have) and make sure is well tested and explained.

[bogdandrutu]

Another thing to look for is that we start first request and stop first request, maybe we should do ref-count and only stop after the same number of starts.

[atoulme]

Before doing this, I would consider better to polish this code and move it to component/componentshared or component/sharedcomponent.

Would it be its own module or part of the component module?

But would like to do a pass on the API (consistency with other APIs that we have) and make sure is well tested and explained.

It probably can use some love, I'll take a look as well if that's ok.

Another thing to look for is that we start first request and stop first request, maybe we should do ref-count and only stop after the same number of starts.

Sounds like a good idea to me!

[bogdandrutu]

Would it be its own module or part of the component module?

No.

It probably can use some love, I'll take a look as well if that's ok.

Please.

Sounds like a good idea to me!

Not sure if it is that easy.

[atoulme]

Not sure if it is that easy.

When did that ever stop me :D

[atoulme]

Closing - let's take this one piecemeal, I'll file issues to follow up.

[atoulme]

I have filed #9156 and #9155. We can keep #4266 to move under component/componentshared.