[chore] add semconvkit to reduce toil #9057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code, copied from the opentelemetry-go repo, allows to generate schema.go automatically as well, reducing effort needed to generate semantic convention packages in the future Signed-off-by: Alex Boten <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9057 +/- ##
=======================================
Coverage 91.55% 91.55%
=======================================
Files 316 316
Lines 17154 17154
=======================================
Hits 15706 15706
Misses 1152 1152
Partials 296 296 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Alex Boten <[email protected]>
TylerHelmuth
reviewed
Dec 8, 2023
| @@ -27,4 +27,6 @@ import ( | |||
| _ "golang.org/x/exp/cmd/apidiff" | |||
| _ "golang.org/x/tools/cmd/goimports" | |||
| _ "golang.org/x/vuln/cmd/govulncheck" | |||
|
|
|||
| _ "go.opentelemetry.io/collector/internal/tools/semconvkit" | |||
There was a problem hiding this comment.
Should this live in go-build-tools?
There was a problem hiding this comment.
Maybe, but I didn't want to block on this. I'm happy to open a follow up issue
Signed-off-by: Alex Boten <[email protected]>
dmitryax
approved these changes
Dec 8, 2023
dmitryax
reviewed
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code, copied from the opentelemetry-go repo, allows to generate schema.go automatically as well, reducing effort needed to generate semantic convention packages in the future