[chore] Fix checkValueForProducer test helper for queue metrics #8288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check assumes that every OC metric has only one datapoint. But, since the queue metrics are defined globally, they are accumulate more datapoints with different labels from different tests. This change removes that assumption. It allows having more tests for the exporter queue without breaking TestQueuedRetry_QueueMetricsReported. Ideally, we should avoid defining instruments globally or clear them up after each test. The first option would require passing the OpenCensus registry in as a public field of TelemetrySettings from the service start. The second option would require a bigger refactoring. I think we can allow several tests emitting datapoints for the global instruments for now until we migrate to OTel metrics.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #8288 +/- ##
=======================================
Coverage 90.18% 90.18%
=======================================
Files 302 302
Lines 15859 15859
=======================================
Hits 14303 14303
Misses 1261 1261
Partials 295 295 ☔ View full report in Codecov by Sentry. |
djaglowski
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkValueForProducertest helper assumes that every OC metric has only one timeseries. But, since the queue metrics are defined globally, they accumulate more timeseries with different labels from different tests. This change removes that assumption. It allows having more tests for the exporter queue without breaking TestQueuedRetry_QueueMetricsReported.Ideally, we should avoid defining instruments globally or clear them up after each test. The first option would require passing the OpenCensus registry in as a public field of TelemetrySettings from the service start. The second option would require a bigger refactoring.
I think we can allow several tests emitting datapoints for the global instruments for now until we migrate to OTel metrics.
Fixes tests failing in #8250