Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Add an automation to skip release if there no changes #7559

Merged

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Apr 24, 2023

As discussed at one of the recent SIGs, we don't want to release module sets with no changes.

This change updates the release process to skip releasing the stable set of modules if there are no changes since the last version.

Generated PR sample: dmitryax#3

@dmitryax dmitryax requested a review from a team as a code owner April 24, 2023 22:34
@dmitryax dmitryax requested a review from codeboten April 24, 2023 22:34
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04 🎉

Comparison is base (b302ace) 91.23% compared to head (c708946) 91.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7559      +/-   ##
==========================================
+ Coverage   91.23%   91.27%   +0.04%     
==========================================
  Files         296      296              
  Lines       14473    14473              
==========================================
+ Hits        13204    13210       +6     
+ Misses       1004      999       -5     
+ Partials      265      264       -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dmitryax dmitryax force-pushed the check-changes-since-last-version branch 3 times, most recently from 544cc1f to f69d732 Compare April 25, 2023 00:17
@dmitryax
Copy link
Member Author

The failing test is unrelated, fixed in #7561

@dmitryax dmitryax force-pushed the check-changes-since-last-version branch 4 times, most recently from 1a67e2a to 000a8ef Compare April 25, 2023 15:34
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on, just a couple of suggestions

.github/workflows/scripts/release-create-tracking-issue.sh Outdated Show resolved Hide resolved
.github/workflows/scripts/release-prepare-release.sh Outdated Show resolved Hide resolved
@dmitryax dmitryax force-pushed the check-changes-since-last-version branch from 000a8ef to a1db568 Compare April 25, 2023 23:09
@dmitryax dmitryax force-pushed the check-changes-since-last-version branch from a1db568 to 4000f90 Compare May 3, 2023 17:26
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens with make push-tags when there's no change? will it fail when trying to create a tag that already exists?

Update the release process to skip releasing the stable set of modules if there are no changes since the last version
@dmitryax dmitryax force-pushed the check-changes-since-last-version branch from 4000f90 to c708946 Compare May 5, 2023 18:33
@dmitryax
Copy link
Member Author

dmitryax commented May 5, 2023

What happens with make push-tags when there's no change? will it fail when trying to create a tag that already exists?

Yes, it'll just fail to push existing tags. I updated the release section for make push-tags to make it clear when to run them

@codeboten codeboten merged commit 9f776d0 into open-telemetry:main May 5, 2023
@github-actions github-actions bot added this to the next release milestone May 5, 2023
@dmitryax dmitryax deleted the check-changes-since-last-version branch May 8, 2023 05:50
dmitryax added a commit to dmitryax/opentelemetry-collector that referenced this pull request May 8, 2023
…elemetry#7559)

Update the release process to skip releasing the stable set of modules if there are no changes since the last version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants