Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Add naming conventions for signal-specific types #7273

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

evan-bradley
Copy link
Contributor

Description:

Add rules in CONTRIBUTING.md that describe how to name types and functions that apply to a specific signal.

Link to tracking Issue:

Resolves #7050

@evan-bradley evan-bradley requested a review from a team as a code owner March 1, 2023 22:18
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.05 🎉

Comparison is base (08985c4) 90.84% compared to head (7718e8d) 90.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7273      +/-   ##
==========================================
+ Coverage   90.84%   90.90%   +0.05%     
==========================================
  Files         293      293              
  Lines       14295    14077     -218     
==========================================
- Hits        12986    12796     -190     
+ Misses       1041     1013      -28     
  Partials      268      268              
Impacted Files Coverage Δ
service/pipelines.go 90.00% <0.00%> (-6.13%) ⬇️
pdata/pmetric/generated_exemplarslice.go 100.00% <0.00%> (ø)
...porter/exporterhelper/internal/persistent_queue.go 100.00% <0.00%> (ø)
confmap/resolver.go 96.75% <0.00%> (+0.01%) ⬆️
service/service.go 68.03% <0.00%> (+0.09%) ⬆️
service/graph.go 98.67% <0.00%> (+0.43%) ⬆️
service/zpages.go 70.58% <0.00%> (+1.17%) ⬆️
featuregate/registry.go 95.58% <0.00%> (+24.93%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codeboten codeboten merged commit 3b9ebae into open-telemetry:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the "standard way for naming per signal types"
2 participants