[chore] [pdata] Migrate the code generator to go templates #7241
Conversation
Codecov ReportBase: 90.99% // Head: 90.99% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #7241 +/- ##
=======================================
Coverage 90.99% 90.99%
=======================================
Files 293 293
Lines 14268 14268
=======================================
Hits 12983 12983
Misses 1017 1017
Partials 268 268
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
9a889f3
to
7f87467
Compare
7f87467
to
21b9b40
Compare
| const accessorSliceTemplate = `// ${fieldName} returns the ${fieldName} associated with this ${structName}. | ||
| func (ms ${structName}) ${fieldName}() ${returnType} { | ||
| return new${returnType}(&ms.${origAccessor}.${fieldName}) | ||
| const accessorSliceTemplate = `// {{ .fieldName }} returns the {{ .fieldName }} associated with this {{ .structName }}. | ||
| func (ms {{ .structName }}) {{ .fieldName }}() {{ .packageName }}{{ .returnType }} { | ||
| {{- if .isCommon }} | ||
| return {{ .packageName }}{{ .returnType }}(internal.New{{ .returnType }}(&ms.{{ .origAccessor }}.{{ .fieldName }})) | ||
| {{- else }} | ||
| return new{{ .returnType }}(&ms.{{ .origAccessor }}.{{ .fieldName }}) | ||
| {{- end }} | ||
| }` | ||
|
|
||
| const accessorSliceTemplateCommon = `// ${fieldName} returns the ${fieldName} associated with this ${structName}. | ||
| func (ms ${structName}) ${fieldName}() ${packageName}${returnType} { | ||
| return ${packageName}${returnType}(internal.New${returnType}(&ms.${origAccessor}.${fieldName})) |
There was a problem hiding this comment.
If I understand correctly, we're now autodetecting whether or not each struct is common based on the package, and this is necessarily part of this change in order to build the map expected by go templates. Is that right?
There was a problem hiding this comment.
now autodetecting whether or not each struct is common based on the package
We've been doing that for a while already. But it's still can be changed if ever needed
This change migrates the env var based templates to go templates to allow more complicated logic in them needed for #7205