Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Retract failed release v0.69.0 #6958

Conversation

MovieStoreGuy
Copy link
Contributor

Description:
Ensuring users can't use v0.69.0 since it failed, should use fixed version v0.69.1

Link to tracking Issue:
#6908

@MovieStoreGuy MovieStoreGuy requested a review from a team as a code owner January 17, 2023 03:19
@MovieStoreGuy
Copy link
Contributor Author

Not sure if pdata v1.0.0-rc2 should also be included.

@dmitryax
Copy link
Member

Not sure if pdata v1.0.0-rc2 should also be included.

pdata modules are all good

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it should be added in all beta modules

go.mod Outdated Show resolved Hide resolved
Co-authored-by: Dmitrii Anoshin <[email protected]>
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Base: 91.08% // Head: 91.08% // No change to project coverage 👍

Coverage data is based on head (df0ce61) compared to base (f2a0133).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6958   +/-   ##
=======================================
  Coverage   91.08%   91.08%           
=======================================
  Files         238      238           
  Lines       14418    14418           
=======================================
  Hits        13133    13133           
  Misses       1033     1033           
  Partials      252      252           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MovieStoreGuy
Copy link
Contributor Author

I believe it should be added in all beta modules

I will add them in a moment, so it is basically all modules that aren't pdata right?

@dmitryax
Copy link
Member

I will add them in a moment, so it is basically all modules that aren't pdata right?

Yes

@MovieStoreGuy
Copy link
Contributor Author

I couldn't retract v0.69.0 from go.opentelemetry.io/collector/cmd/otelcorecol since the builder does't support retract.

Not sure if that is going to be an issue.

@dmitryax
Copy link
Member

since the builder does't support retract.

What do you mean? How doesn't it support retract?

@bogdandrutu bogdandrutu merged commit bf91c9e into open-telemetry:main Jan 17, 2023
@bogdandrutu
Copy link
Member

What do you mean? How doesn't it support retract?

The go.mod file is generated by the otelcol builder, and that does not support retract statements.

codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this pull request Jan 23, 2023
* Adding retraction for failed release

* Update go.mod

Co-authored-by: Dmitrii Anoshin <[email protected]>

* Adding retract statements to public modules

* Running mod tidy on retracted files

* Removing auto generated mod file

Co-authored-by: Dmitrii Anoshin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants