Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Unmarshal[*]Config in favor of UnmarshalConfig #6613

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Deprecate Unmarshal[*]Config in favor of UnmarshalConfig #6613

merged 1 commit into from
Nov 23, 2022

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Nov 23, 2022 •
edited
Loading

Updates #6578

@bogdandrutu bogdandrutu requested a review from a team as a code owner November 23, 2022 17:29
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 91.09% // Head: 91.09% // No change to project coverage 👍

Coverage data is based on head (4e2396a) compared to base (c914964).
Patch coverage: 30.76% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6613   +/-   ##
=======================================
  Coverage   91.09%   91.09%           
=======================================
  Files         243      243           
  Lines       14105    14105           
=======================================
  Hits        12849    12849           
  Misses       1006     1006           
  Partials      250      250
Impacted Files Coverage Δ
component/config.go 87.50% <0.00%> (ø)
component/exporter.go 96.07% <0.00%> (ø)
component/extension.go 86.66% <0.00%> (ø)
component/processor.go 96.07% <0.00%> (ø)
component/receiver.go 96.07% <0.00%> (ø)
service/internal/configunmarshaler/exporters.go 100.00% <100.00%> (ø)
service/internal/configunmarshaler/extensions.go 100.00% <100.00%> (ø)
service/internal/configunmarshaler/processors.go 100.00% <100.00%> (ø)
service/internal/configunmarshaler/receivers.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu bogdandrutu merged commit 30c9c71 into open-telemetry:main Nov 23, 2022
@bogdandrutu bogdandrutu deleted the depunmarshal branch November 23, 2022 18:15
jaronoff97 pushed a commit to lightstep/opentelemetry-collector that referenced this pull request Dec 14, 2022
@bogdandrutu @jaronoff97
Deprecate Unmarshal[*]Config in favor of UnmarshalConfig (open-teleme…
d56de86 
…try#6613)

Signed-off-by: Bogdan Drutu <[email protected]>

Signed-off-by: Bogdan Drutu <[email protected]>
jaronoff97 pushed a commit to lightstep/opentelemetry-collector that referenced this pull request Dec 14, 2022
@bogdandrutu @jaronoff97
Deprecate Unmarshal[*]Config in favor of UnmarshalConfig (open-teleme…
da7d4db 
…try#6613)

Signed-off-by: Bogdan Drutu <[email protected]>

Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bogdandrutu @mx-psi