Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crosslink tool #6237

Merged
merged 5 commits into from
Oct 5, 2022
Merged

Conversation

bryan-aguilar
Copy link
Contributor

Description: Adds the crosslink tool to simplify the function of adding replace statements to intra-repository go modules.

Please delete paragraphs that you did not use before submitting.

@bryan-aguilar bryan-aguilar requested a review from a team as a code owner October 5, 2022 02:46
@bryan-aguilar
Copy link
Contributor Author

Can this PR get a skip changelog label?

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 92.22% // Head: 92.22% // No change to project coverage 👍

Coverage data is based on head (cf4dc8e) compared to base (3c12ddf).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6237   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         219      219           
  Lines       13484    13484           
=======================================
  Hits        12435    12435           
  Misses        819      819           
  Partials      230      230           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 5, 2022
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make this step part of github action "check" and if git diffs then fail.

Makefile Outdated Show resolved Hide resolved
@bryan-aguilar
Copy link
Contributor Author

bryan-aguilar commented Oct 5, 2022

Updated GHA and make directive.

I also added the --prune flag as default. Since this will be running on PR build it should continue to keep the modules clean. You can see the details of the prune command here.

@bogdandrutu bogdandrutu merged commit e0eea95 into open-telemetry:main Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants