Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Improve startup error message #5978

Merged
merged 4 commits into from
Aug 26, 2022

Conversation

TylerHelmuth
Copy link
Member

Description:
Update's the collector's execute command to return a more usable error message when no configuration is provided.

Link to tracking Issue:
Fixes #5648

Testing:
Scenario already covered in existing unit test.

@TylerHelmuth TylerHelmuth requested a review from a team as a code owner August 26, 2022 15:02
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #5978 (51069ca) into main (940943c) will decrease coverage by 0.10%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #5978      +/-   ##
==========================================
- Coverage   92.24%   92.14%   -0.11%     
==========================================
  Files         212      212              
  Lines       13263    13269       +6     
==========================================
- Hits        12235    12227       -8     
- Misses        811      824      +13     
- Partials      217      218       +1     
Impacted Files Coverage Δ
service/command.go 54.54% <83.33%> (-24.03%) ⬇️
service/flags.go 80.76% <0.00%> (-7.70%) ⬇️
service/config_provider.go 76.92% <0.00%> (-7.70%) ⬇️
...er/loggingexporter/internal/otlptext/databuffer.go 99.12% <0.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User experience: starting the collector without config file yields a cryptic message
2 participants