Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry Query Language] Iterate on processing doc #5356

Merged
merged 5 commits into from
May 13, 2022

Conversation

TylerHelmuth
Copy link
Member

Description:
This PR continues to mature the processing.md doc.

  • Updates the metric's virtual field to be in alignment with recent discussions/PRs.
  • Introduces the start of expected function syntax.

@TylerHelmuth TylerHelmuth requested review from a team and bogdandrutu May 12, 2022 17:31
@TylerHelmuth
Copy link
Member Author

/cc @bogdandrutu @tigrannajaryan @anuraaga @djaglowski as interested parties of the transform processor/telemetry query language

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #5356 (e36455b) into main (c368d49) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5356      +/-   ##
==========================================
+ Coverage   90.60%   90.64%   +0.03%     
==========================================
  Files         190      190              
  Lines       11429    11422       -7     
==========================================
- Hits        10355    10353       -2     
+ Misses        853      850       -3     
+ Partials      221      219       -2     
Impacted Files Coverage Δ
pdata/internal/common.go 91.82% <0.00%> (-0.75%) ⬇️
internal/configunmarshaler/defaultunmarshaler.go
...e/internal/configunmarshaler/defaultunmarshaler.go 100.00% <0.00%> (ø)
config/configtelemetry/configtelemetry.go 100.00% <0.00%> (+9.67%) ⬆️
service/config_provider.go 90.32% <0.00%> (+14.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c368d49...e36455b. Read the comment docs.

Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good clarification

@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 13, 2022
@bogdandrutu bogdandrutu merged commit a99ca17 into open-telemetry:main May 13, 2022
@TylerHelmuth TylerHelmuth deleted the update-processing-doc branch May 16, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants