Fix check links errors, use latest version of the tool #5199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
checklinks
branch
2 times, most recently
from
b56e726
to
cd8c4f0
Compare
Codecov Report
@@ Coverage Diff @@
## main #5199 +/- ##
==========================================
- Coverage 90.35% 90.32% -0.04%
==========================================
Files 188 188
Lines 11057 11057
==========================================
- Hits 9991 9987 -4
- Misses 841 844 +3
- Partials 225 226 +1
Continue to review full report at Codecov.
|
bogdandrutu
commented
Apr 12, 2022
| |---------- |---------------------------------------------- |-------------------------------------------------------------------------------------------------------------------------- | | ||
| | Hashing | ["hashing/fnv"](https://pkg.go.dev/hash/fnv) | The project adopted this as the default hashing method due to the efficiency and is reasonable for non cryptographic use | | ||
| | Testing | Use `t.Parallel()` where possible | Enabling more test to be run in parallel will speed up the feedback process when working on the project. | | ||
| | Scenario | Recommended | Rationale | |
There was a problem hiding this comment.
Random nits fixed in CONTRIBUTING.md to prove things work.
There was a problem hiding this comment.
This was intelij idea complaining that the table is not well formatted, so I pressed the button to fix that :)
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
commented
Apr 12, 2022
| @@ -41,8 +41,7 @@ reasonably fast reviews. | |||
|
|
|||
| ### When adding a new component | |||
|
|
|||
| Consider submitting different PRs for (more details about adding new components | |||
There was a problem hiding this comment.
This is fixed because the new check actually works, see https://github.com/open-telemetry/opentelemetry-collector/runs/5999196053?check_suite_focus=true
bogdandrutu
added
the
Skip Changelog
Nicholaswang
pushed a commit
to Nicholaswang/opentelemetry-collector
that referenced
this pull request
Jun 7, 2022
…y#5199) * Fix check links errors, use latest version of the tool See https://github.com/open-telemetry/opentelemetry-collector/runs/5999091156?check_suite_focus=true Signed-off-by: Bogdan Drutu <[email protected]> * Fix broken links in CONTRIBUTING.md Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/open-telemetry/opentelemetry-collector/runs/5999091156?check_suite_focus=true
Signed-off-by: Bogdan Drutu [email protected]