Change Jaeger receiver config #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
requested review from
bogdandrutu,
flands,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
|
@owais you will need to also update E2E tests to generate the config correctly. |
tigrannajaryan
approved these changes
Jan 21, 2020
pjanotti
approved these changes
Jan 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #510 +/- ##
=========================================
+ Coverage 76.05% 76.1% +0.05%
=========================================
Files 123 123
Lines 7639 7639
=========================================
+ Hits 5810 5814 +4
+ Misses 1553 1550 -3
+ Partials 276 275 -1
Continue to review full report at Codecov.
|
We use underscores instead of dashes by convention in all component configuration. Jaeger receiver used dashes. This commit brings jaeger receiver in line with the rest of the components.
|
@pjanotti removed circleci to make this pass. |
pjanotti
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jan 22, 2020
This fixes recent inconsistent changes made to the jaeger receiver. open-telemetry/opentelemetry-collector#510
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Scripts for releasing. - fixes open-telemetry#510 * fix review comments. Co-authored-by: Joshua MacDonald <[email protected]>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…y#510) Bumps [boto3](https://github.com/boto/boto3) from 1.17.99 to 1.17.100. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.17.99...1.17.100) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use underscores instead of dashes by convention in all component
configuration. Jaeger receiver used dashes. This commit brings jaeger
receiver in line with the rest of the components.