Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning about already removed config value #4696

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested a review from a team as a code owner January 18, 2022 17:58
@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 18, 2022
@bogdandrutu bogdandrutu enabled auto-merge (squash) January 18, 2022 18:01
@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #4696 (2d6ce04) into main (1621c2e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4696   +/-   ##
=======================================
  Coverage   90.74%   90.74%           
=======================================
  Files         180      180           
  Lines       10649    10649           
=======================================
  Hits         9663     9663           
  Misses        765      765           
  Partials      221      221           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1621c2e...2d6ce04. Read the comment docs.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is still in the code:

const ballastSizeMibKey = "ballast_size_mib"

@bogdandrutu bogdandrutu merged commit 4a89a13 into open-telemetry:main Jan 18, 2022
@bogdandrutu
Copy link
Member Author

@codeboten see #4697, I thought about merging the PRs, but one fixes a reference for memlimit config, the other a reference to the new ballast extension config, so they refer to different configs.

@bogdandrutu bogdandrutu deleted the fixmemreadme branch January 18, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants