Make sure otlphttp exporter tests include TraceID and SpanID #4268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to open-telemetry#4221 There was a report that TraceID and SpanID are correupted by otlphttp exporter. I added to TraceID and SpanID to try to reproduce the bug. The bug is not reproduced but keeping these in the test is useful.
codeboten
reviewed
Oct 26, 2021
Yes, here (I verified). |
bogdandrutu
approved these changes
Oct 26, 2021
Codecov Report
@@ Coverage Diff @@
## main #4268 +/- ##
==========================================
+ Coverage 88.20% 88.22% +0.02%
==========================================
Files 173 173
Lines 10327 10320 -7
==========================================
- Hits 9109 9105 -4
+ Misses 978 975 -3
Partials 240 240
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4221
There was a report that TraceID and SpanID are correupted by otlphttp exporter.
I added to TraceID and SpanID to try to reproduce the bug. The bug is not reproduced
but keeping these in the test is useful.