update oc internal, prometheus exporters to use attributes #3770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
force-pushed
the
codeboten/0.9.0-attributes-2
branch
from
74114dd
to
13ead4d
Compare
|
Needs a rebase |
codeboten
force-pushed
the
codeboten/0.9.0-attributes-2
branch
from
13ead4d
to
72e57f3
Compare
| l[key] = prompb.Label{ | ||
| Name: sanitize(key), | ||
| Value: value, | ||
| Value: value.StringVal(), // TODO(codeboten): Decide what to do with non-string attributes. |
There was a problem hiding this comment.
We should probably stringify non-string attributes. Unclear what encoding to use though for non-primitive types. Perhaps json-string or something like that since that's also what Otel spec recommends for exporting array attributes when arrays are not natively supported in the target format: https://github.com/open-telemetry/opentelemetry-specification/blob/7cef355a15c4430aa323d155206a2945fcd67a05/specification/common/common.md#attributes
There was a problem hiding this comment.
Sure i can open a separate issue to track that work
There was a problem hiding this comment.
Please open the issue to not forget :)
carlosalberto
approved these changes
Aug 10, 2021
14 tasks
bogdandrutu
reviewed
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Started moving code from labels to attributes. I initially started with the ocinternal and then ended up having to make a few more changes in order to get all the tests passing. If this change is too big to be reviewed I'm happy to refactor.
Link to tracking Issue: Part of #3535
Testing: Updated all the existing tests
Followup to #3761