Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access Ballast extension in Memory Limiter via Host.GetExtensions #3634

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

mxiamxia
Copy link
Member

Description: <Describe what has changed.

  • Remove the global ballast size variable in ballast extension
  • Access Ballast extension in Memory Limiter processor via Host.GetExtensions

Link to tracking Issue:
#2516

@mxiamxia mxiamxia requested review from a team and tigrannajaryan July 16, 2021 05:12
@mxiamxia
Copy link
Member Author

Access Ballast extension in Memory Limiter processor via Host.GetExtensions was suggested in this comment. (#3532 (comment))

@alolita
Copy link
Member

alolita commented Jul 19, 2021

@tigrannajaryan can you please review - this is a required task for us to get to our tracing stability milestone this month. Ty!

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, just a couple minor comments.

processor/memorylimiter/memorylimiter.go Outdated Show resolved Hide resolved
processor/memorylimiter/memorylimiter.go Outdated Show resolved Hide resolved
@mxiamxia
Copy link
Member Author

Generally LGTM, just a couple minor comments.

Thanks @tigrannajaryan . Addressed the comments. PTAL.

@tigrannajaryan tigrannajaryan merged commit 062e64f into open-telemetry:main Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants