Copy contrib's storage interface to core #3425
Conversation
|
Before we review/merge this let's make sure we are happy about the direction that #3274 goes into. I want to make sure the disk buffering use case is nicely handled by this storage interface. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
c7b2c51
to
e287dc4
Compare
|
@pmm-sumo is this up-to-date and ready for review? |
@tigrannajaryan there's one suggestion I mentioned above (and going to apply it) and other than that it's up-to-date. API + implementation is also available in opentelemetry-collector-contrib PR#4145 (there are several strategies how we might apply those changes altogether, one is that we could merge API first, then update contrib's core version, extract implementation into a separate PR and merge it) EDIT: I have just applied the suggestion on operation type and rebased with |
8810ad8
to
508df28
Compare
|
@pmm-sumo I will merge after you respond/resolve comments (non of my comments are blocking). |
Co-authored-by: Tigran Najaryan <[email protected]>
|
@pmm-sumo thanks for patience! |
Description: As discussed during the SIG, we want to move storage extension to core, starting with the interface (this PR) so persistent buffer implementation (#2285) could use it
Link to tracking Issue: #3424
Testing: Just the interface, no tests
Documentation: README.md with API
cc @djaglowski @tigrannajaryan