Fix otlpreceiver README (was incorrect about bytes being base64 encoded) #3123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment was about traceid/spanid "bytes" fields. This comment is incorrect since we have changed traceid/spanid fields to use hex encoding (as required by the spec). In the future if we add any other "bytes" fields to the proto they will be encoded as base64 as it is expected and is default behavior of Protobuf/JSON, but this does not require an explicit comment, so I am deleting it.
bogdandrutu
approved these changes
May 7, 2021
dashpole
pushed a commit
to dashpole/opentelemetry-collector
that referenced
this pull request
Jun 14, 2021
…ed) (open-telemetry#3123) The comment was about traceid/spanid "bytes" fields. This comment is incorrect since we have changed traceid/spanid fields to use hex encoding (as required by the spec). In the future if we add any other "bytes" fields to the proto they will be encoded as base64 as it is expected and is default behavior of Protobuf/JSON, but this does not require an explicit comment, so I am deleting it.
ankitnayan
pushed a commit
to SigNoz/opentelemetry-collector
that referenced
this pull request
Jul 27, 2021
…ed) (open-telemetry#3123) The comment was about traceid/spanid "bytes" fields. This comment is incorrect since we have changed traceid/spanid fields to use hex encoding (as required by the spec). In the future if we add any other "bytes" fields to the proto they will be encoded as base64 as it is expected and is default behavior of Protobuf/JSON, but this does not require an explicit comment, so I am deleting it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment was about traceid/spanid "bytes" fields. This comment is incorrect since
we have changed traceid/spanid fields to use hex encoding (as required by the spec).
In the future if we add any other "bytes" fields to the proto they will be encoded as base64
as it is expected and is default behavior of Protobuf/JSON, but this does not require an
explicit comment, so I am deleting it.