Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[otlpexporter] support validation for dns:https:// and dns:https:/// #10450

Merged
merged 5 commits into from
Jul 1, 2024
Merged

[otlpexporter] support validation for dns:https:// and dns:https:/// #10450

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7fded3a
[configgrpc] support validation for dns:https:// and dns:https:///
codeboten Jun 20, 2024
cb90763
changelog
codeboten Jun 20, 2024
f00600d
update test
codeboten Jun 20, 2024
2b4d8da
update changelog
codeboten Jun 20, 2024
28f7432
Update exporter/otlpexporter/config_test.go
TylerHelmuth Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update test 
Signed-off-by: Alex Boten <[email protected]>
  • Loading branch information
@codeboten
codeboten committed Jun 20, 2024
commit f00600daa59a82e649ff736c6ff85b216a1c61a0
4 changes: 2 additions & 2 deletions exporter/otlpexporter/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,8 @@ func TestValidDNSEndpoint(t *testing.T) {
func TestSanitizeEndpoint(t *testing.T) {
codeboten marked this conversation as resolved.
Show resolved Hide resolved
factory := NewFactory()
cfg := factory.CreateDefaultConfig().(*Config)
cfg.Endpoint = "dns:https://backend.example.com:4317"
assert.Equal(t, "backend.example.com:4317", cfg.sanitizedEndpoint())
cfg.Endpoint = "dns:https://authority/backend.example.com:4317"
assert.Equal(t, "authority/backend.example.com:4317", cfg.sanitizedEndpoint())
cfg.Endpoint = "dns:https:///backend.example.com:4317"
assert.Equal(t, "backend.example.com:4317", cfg.sanitizedEndpoint())
cfg.Endpoint = "dns:https:////backend.example.com:4317"
Expand Down
Loading