Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configretry] Mark as stable #10341

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jun 5, 2024

Description

Mark module as stable.

Link to tracking issue

Fixes #10279

@atoulme atoulme requested review from a team and codeboten June 5, 2024 23:08
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.57%. Comparing base (1e44a9c) to head (3178438).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10341   +/-   ##
=======================================
  Coverage   92.57%   92.57%           
=======================================
  Files         387      387           
  Lines       18256    18256           
=======================================
  Hits        16900    16900           
  Misses       1010     1010           
  Partials      346      346           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs explicit discussion on the mapstructure tags but once that is done LGTM

@codeboten
Copy link
Contributor

Will bring up this issue (#10412) at the next SIG call to chime in on. Unless anything is heard, I will close that issue later this week and I think we can merge this PR shortly after

@codeboten codeboten merged commit 72c23aa into open-telemetry:main Jun 20, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilize module go.opentelemetry.io/collector/config/configretry
3 participants