Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E2E test for Zipkin format #482

Closed
tigrannajaryan opened this issue Jan 3, 2020 · 5 comments
Closed

Add E2E test for Zipkin format #482

tigrannajaryan opened this issue Jan 3, 2020 · 5 comments
Assignees
@mat-rumian
Labels
help wanted Good issue for contributors to OpenTelemetry Service to pick up

Comments

@tigrannajaryan
Copy link
Member

tigrannajaryan commented Jan 3, 2020 •
edited
Loading

This requires DataSender and DataReceiver for the testbed.

See how it is done for other formats here: https://github.com/open-telemetry/opentelemetry-collector/blob/master/testbed/testbed/senders.go and https://github.com/open-telemetry/opentelemetry-collector/blob/master/testbed/testbed/receivers.go

The new format needs to be enabled in https://github.com/open-telemetry/opentelemetry-collector/blob/master/testbed/tests/trace_test.go
@tigrannajaryan tigrannajaryan added the help wanted Good issue for contributors to OpenTelemetry Service to pick up label Jan 3, 2020
@tigrannajaryan
Copy link
Member Author

@mrumian-sumo feel free to work on this. Github does not let me assign this to you for some reason.

@tigrannajaryan
Copy link
Member Author

@mat-rumian

@bogdandrutu
Copy link
Member

@mat-rumian you need to write something here so I can assign the issue to you :)

@mat-rumian mat-rumian mentioned this issue Mar 23, 2020
Merged
@mat-rumian
Copy link
Contributor

Hello :)

tigrannajaryan pushed a commit that referenced this issue Apr 20, 2020
@mat-rumian
Add Zipkin tests to testbed (#681)
800c5c6 
I've added Zipkin data receiver and sender for testbed. Few tests were updated and two new created.

**Link to tracking Issue:**
[Issue-482](#482)

**Testing:** 
- TestGeneratorAndBackend -> changed the test name, Jaeger and Zipkin as test cases
- TraceNoBackend10kSPS -> created test scenario, possibility to add new test cases
- Trace10kSPS -> added Zipkin test case
@kbrockhoff
Copy link
Member

Correctness tests for Zipkin receiver and exporter are included in PR #1062

wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this issue Jul 13, 2020
@mat-rumian @wyTrivail
Add Zipkin tests to testbed (open-telemetry#681)
1f83f66 
I've added Zipkin data receiver and sender for testbed. Few tests were updated and two new created.

**Link to tracking Issue:**
[Issue-482](open-telemetry#482)

**Testing:** 
- TestGeneratorAndBackend -> changed the test name, Jaeger and Zipkin as test cases
- TraceNoBackend10kSPS -> created test scenario, possibility to add new test cases
- Trace10kSPS -> added Zipkin test case
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
@wingyplus @rghetia
exporter/metric/prometheus: fix incorrect code format comments for In…
f9a5484 
…stallNewPipeline (open-telemetry#482)

Co-authored-by: Rahul Patel <[email protected]>
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
@jeffreyc-splunk
Add auto retry for gitlab or signing service flakiness (open-telemetr…
6cb1860 
…y#482)
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
@kxyr
Use attribute_utils.h from common instead of trace (open-telemetry#482)
c8db847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mat-rumian mat-rumian

Labels
help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bogdandrutu @kbrockhoff @tigrannajaryan @mat-rumian