Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run full builds on manifest change #91

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Run full builds on manifest change #91

merged 1 commit into from
Mar 22, 2022

Conversation

jpkrohling
Copy link
Member

Fixes #85

Signed-off-by: Juraci Paixão Kröhling [email protected]

@jpkrohling
Run full builds on manifest change
0246a05 
Fixes open-telemetry#85

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@jpkrohling jpkrohling requested a review from a team as a code owner March 21, 2022 18:18
@jpkrohling
Copy link
Member Author

@mx-psi, would you mind reviewing this one?

mx-psi
mx-psi approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (--snapshot already implies the flags I mentioned on the issue)

@jpkrohling jpkrohling merged commit 5fb23d0 into open-telemetry:main Mar 22, 2022
@jpkrohling jpkrohling deleted the jpkrohling/issue85 branch March 22, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run all release builds on PRs
2 participants
@jpkrohling @mx-psi