[receiver/expvarreceiver] Overall structure for new expvarreceiver #9747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ## Configuration | ||
|
|
||
| ### Default |
There was a problem hiding this comment.
Once we know the list of default metrics we are going to export, we should add them here in that PR with an example of how to disable them if you're not interested in gc_pause.time for example.
|
Hi @dmitryax would you be able to take a look at this PR? 😃 |
djaglowski
reviewed
May 10, 2022
Co-authored-by: Daniel Jaglowski <[email protected]>
|
RE the changelog checks - I will update it once this PR is approved and ready to be merged. It's the kind of thing that gets a conflict every time I rebase on master because of other things being added to the changelog constantly. |
djaglowski
approved these changes
May 11, 2022
|
Thanks for the review @djaglowski! - changelog is updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR is the initial Config and Factory implementations for the expvar receiver. There is no receiver implementation yet, it is just a skeleton and basic test for loading config from yaml.
The
expvarreceiverintends to collect memstats from Golang applications. The configuration options are collection interval, http client config, and enabling/disabling metrics by name.Link to tracking Issue: #9592
Testing: Basic tests for config validation. More rigorous unit tests will be added when there is more implementation to test.
Documentation: The README details configuration options and defaults. It doesn't yet go into details on the
metricssection because the list of metrics names from memstats still needs to be defined by the receiver.