Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core to v0.2.3 #96

Merged

Conversation

tigrannajaryan
Copy link
Member

No description provided.

Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo on the Makefile but other than that LGTM

Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tigrannajaryan tigrannajaryan merged commit 297c713 into open-telemetry:master Jan 15, 2020
@tigrannajaryan tigrannajaryan deleted the feature/tigran/updatedep branch January 15, 2020 15:33
mxiamxia referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 22, 2020
Added a Sleep to work around a data race bug in Jaeger
(jaegertracing/jaeger#1625) caused
by stopping immediately after starting.

Without this Sleep we were observing this bug on our side:
open-telemetry/opentelemetry-collector#43
The Sleep ensures that Jaeger Start() is fully completed before
we call Jaeger Stop().

TODO: Jaeger bug is already fixed, remove this once we update Jaeger
to latest version.

Testing done: make test
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
* add exported value for traceOptionBitMaskUnused (for testing)

* move key_test to package core_test

* add span_context_test to package core_test
codeboten pushed a commit that referenced this pull request Nov 23, 2022
jj22ee pushed a commit to jj22ee/opentelemetry-collector-contrib that referenced this pull request Sep 22, 2023
* tweaks for enhanced container insights metrics

* run go mod tidy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants