Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/datadog] Add api.fail_on_invalid_key to fail fast if API Key is invalid #9426

Merged
merged 11 commits into from
May 5, 2022
Merged

[exporter/datadog] Add api.fail_on_invalid_key to fail fast if API Key is invalid #9426

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
14f929f
add new `fail_on_invalid_key` option
keisku Apr 25, 2022
8150b63
improve the description of fail_on_invalid_key
keisku Apr 27, 2022
f375265
avoid failing when a transient network error
keisku Apr 27, 2022
d8e4a89
remove unnecessary comment
keisku Apr 27, 2022
624b4a1
utils.ValidateAPI() returns error
keisku Apr 27, 2022
e3c8cf2
add tests
keisku Apr 27, 2022
006a462
not returning error when api failure
keisku Apr 28, 2022
80edbdb
fix test names
keisku Apr 28, 2022
368e67d
fix lint
keisku Apr 28, 2022
b6ac7f9
fix go vet: prevent possible context leak
keisku Apr 28, 2022
2a6d697
Merge branch 'main' into keisku/validate-api-key
May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions exporter/datadogexporter/factory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ func (f *factory) createTracesExporter(
}

ctx, cancel := context.WithCancel(ctx)
defer cancel()
mx-psi marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this cancels the exporter prematurely after the function exits. The cancel is only meant to be called on shutdown (it is part of shutdown, so technically it does get called on all paths).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(it is part of shutdown, so technically it does get called on all paths).

the lint was failing because it was not called when the traces exporter fails to get created. I opened #9797 to fix this, thanks for spotting that!

var pushTracesFn consumer.ConsumeTracesFunc

if cfg.OnlyMetadata {
Expand Down