Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update github.com/influxdata/influxdb-observability to v0.2.17 #9226

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Update github.com/influxdata/influxdb-observability to v0.2.17 #9226

merged 1 commit into from
Apr 12, 2022

Conversation

tigrannajaryan
Copy link
Member

The new version no longer uses the deprecated LogRecord.Name field.
The update is necessary to delete the LogRecord.Name.

@tigrannajaryan
Update github.com/influxdata/influxdb-observability to v0.2.17
f31de7d 
The new version no longer uses the deprecated LogRecord.Name field.
The update is necessary to delete the LogRecord.Name.
@tigrannajaryan tigrannajaryan requested a review from a team as a code owner April 12, 2022 14:20
@tigrannajaryan tigrannajaryan added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 12, 2022
codeboten
codeboten approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build failure appears unrelated. triggered the build again

@tigrannajaryan
Copy link
Member Author

Unrelated test failure:

2022-04-12T14:48:16.4400081Z make[2]: Entering directory '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/k8sclusterreceiver'
2022-04-12T14:48:16.4455143Z go test -race -v -timeout 300s --tags="" ./...
2022-04-12T14:48:40.8042041Z === RUN   TestLoadConfig
2022-04-12T14:48:40.8042764Z --- PASS: TestLoadConfig (0.01s)
2022-04-12T14:48:40.8043092Z === RUN   TestFactory
2022-04-12T14:48:40.8043438Z --- PASS: TestFactory (0.01s)
2022-04-12T14:48:40.8043780Z === RUN   TestFactoryDistributions
2022-04-12T14:48:40.8044188Z --- PASS: TestFactoryDistributions (0.00s)
2022-04-12T14:48:40.8044537Z === RUN   TestReceiver
2022-04-12T14:48:40.8045060Z E0412 14:48:40.784307   55547 runtime.go:78] Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference)
2022-04-12T14:48:40.8045498Z goroutine 48 [running]:
2022-04-12T14:48:40.8045872Z k8s.io/apimachinery/pkg/util/runtime.logPanic({0x24e42e0?, 0x386a280?})
2022-04-12T14:48:40.8046350Z 	/home/runner/go/pkg/mod/k8s.io/[email protected]/pkg/util/runtime/runtime.go:74 +0xe6
2022-04-12T14:48:40.8046786Z k8s.io/apimachinery/pkg/util/runtime.HandleCrash({0x0, 0x0, 0xc0001258e8?})
2022-04-12T14:48:40.8047250Z 	/home/runner/go/pkg/mod/k8s.io/[email protected]/pkg/util/runtime/runtime.go:48 +0xb0
2022-04-12T14:48:40.8047612Z panic({0x24e42e0, 0x386a280})
2022-04-12T14:48:40.8047988Z 	/opt/hostedtoolcache/go/1.18.0/x64/src/runtime/panic.go:844 +0x258
2022-04-12T14:48:40.8048573Z k8s.io/client-go/tools/cache.(*Reflector).ListAndWatch.func1(0xc0001ca1c0, 0xc0002321b0, 0xc0005c6000, 0xc000125b40)
2022-04-12T14:48:40.8049170Z 	/home/runner/go/pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:319 +0x126e
2022-04-12T14:48:40.8049697Z k8s.io/client-go/tools/cache.(*Reflector).ListAndWatch(0xc0001ca1c0, 0xc0005c6000)
2022-04-12T14:48:40.8050528Z 	/home/runner/go/pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:361 +0x2f6
2022-04-12T14:48:40.8050992Z k8s.io/client-go/tools/cache.(*Reflector).Run.func1()
2022-04-12T14:48:40.8051512Z 	/home/runner/go/pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:221 +0x45
2022-04-12T14:48:40.8051938Z k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1(0xc0005dc6e0)
2022-04-12T14:48:40.8052392Z 	/home/runner/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:155 +0x49
2022-04-12T14:48:40.8052844Z k8s.io/apimachinery/pkg/util/wait.BackoffUntil(0xc000060540?, {0x2ab0200, 0xc0001122d0}, 0x1, 0xc0005c6000)
2022-04-12T14:48:40.8053310Z 	/home/runner/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:156 +0xcf
2022-04-12T14:48:40.8053818Z k8s.io/client-go/tools/cache.(*Reflector).Run(0xc0001ca1c0, 0xc0005c6000)
2022-04-12T14:48:40.8054360Z 	/home/runner/go/pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:220 +0x29f
2022-04-12T14:48:40.8054788Z k8s.io/apimachinery/pkg/util/wait.(*Group).StartWithChannel.func1()
2022-04-12T14:48:40.8055244Z 	/home/runner/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:56 +0x3f
2022-04-12T14:48:40.8055639Z k8s.io/apimachinery/pkg/util/wait.(*Group).Start.func1()
2022-04-12T14:48:40.8056070Z 	/home/runner/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:73 +0x74
2022-04-12T14:48:40.8056468Z created by k8s.io/apimachinery/pkg/util/wait.(*Group).Start
2022-04-12T14:48:40.8056892Z 	/home/runner/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:71 +0xdd
2022-04-12T14:48:40.8057455Z panic: runtime error: invalid memory address or nil pointer dereference [recovered]
2022-04-12T14:48:40.8057917Z 	panic: runtime error: invalid memory address or nil pointer dereference
2022-04-12T14:48:40.8058173Z 
2022-04-12T14:48:40.8058331Z goroutine 48 [running]:
2022-04-12T14:48:40.8058689Z k8s.io/apimachinery/pkg/util/runtime.HandleCrash({0x0, 0x0, 0xc0001258e8?})
2022-04-12T14:48:40.8059158Z 	/home/runner/go/pkg/mod/k8s.io/[email protected]/pkg/util/runtime/runtime.go:55 +0x145
2022-04-12T14:48:40.8059527Z panic({0x24e42e0, 0x386a280})
2022-04-12T14:48:40.8059900Z 	/opt/hostedtoolcache/go/1.18.0/x64/src/runtime/panic.go:844 +0x258
2022-04-12T14:48:40.8060480Z k8s.io/client-go/tools/cache.(*Reflector).ListAndWatch.func1(0xc0001ca1c0, 0xc0002321b0, 0xc0005c6000, 0xc000125b40)
2022-04-12T14:48:40.8061060Z 	/home/runner/go/pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:319 +0x126e
2022-04-12T14:48:40.8061606Z k8s.io/client-go/tools/cache.(*Reflector).ListAndWatch(0xc0001ca1c0, 0xc0005c6000)
2022-04-12T14:48:40.8062160Z 	/home/runner/go/pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:361 +0x2f6
2022-04-12T14:48:40.8062615Z k8s.io/client-go/tools/cache.(*Reflector).Run.func1()
2022-04-12T14:48:40.8063136Z 	/home/runner/go/pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:221 +0x45
2022-04-12T14:48:40.8063557Z k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1(0xc0005dc6e0)
2022-04-12T14:48:40.8064018Z 	/home/runner/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:155 +0x49
2022-04-12T14:48:40.8064471Z k8s.io/apimachinery/pkg/util/wait.BackoffUntil(0xc000060540?, {0x2ab0200, 0xc0001122d0}, 0x1, 0xc0005c6000)
2022-04-12T14:48:40.8064936Z 	/home/runner/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:156 +0xcf
2022-04-12T14:48:40.8065436Z k8s.io/client-go/tools/cache.(*Reflector).Run(0xc0001ca1c0, 0xc0005c6000)
2022-04-12T14:48:40.8065975Z 	/home/runner/go/pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:220 +0x29f
2022-04-12T14:48:40.8067089Z k8s.io/apimachinery/pkg/util/wait.(*Group).StartWithChannel.func1()
2022-04-12T14:48:40.8067487Z 	/home/runner/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:56 +0x3f
2022-04-12T14:48:40.8067823Z k8s.io/apimachinery/pkg/util/wait.(*Group).Start.func1()
2022-04-12T14:48:40.8068191Z 	/home/runner/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:73 +0x74
2022-04-12T14:48:40.8068536Z created by k8s.io/apimachinery/pkg/util/wait.(*Group).Start
2022-04-12T14:48:40.8069004Z 	/home/runner/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:71 +0xdd
2022-04-12T14:48:40.8069562Z FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/k8sclusterreceiver	0.126s

@tigrannajaryan tigrannajaryan mentioned this pull request Apr 12, 2022
Closed
@pmm-sumo pmm-sumo added the ready to merge Code review completed; ready to merge by maintainers label Apr 12, 2022
@pmm-sumo
Copy link
Contributor

pmm-sumo commented Apr 12, 2022 •
edited
Loading

I triggered the build again, the flaky test failed one more time

@pmm-sumo pmm-sumo added ready to merge Code review completed; ready to merge by maintainers and removed ready to merge Code review completed; ready to merge by maintainers labels Apr 12, 2022
@pmm-sumo
Copy link
Contributor

Build all-green now, so labeling as ready-to-merge

@tigrannajaryan tigrannajaryan merged commit a74d7a7 into open-telemetry:main Apr 12, 2022
@tigrannajaryan tigrannajaryan deleted the feature/tigran/update-influxdb branch April 12, 2022 20:26
@tigrannajaryan tigrannajaryan mentioned this pull request Apr 12, 2022
Merged
@ahayworth ahayworth mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@dmitryax dmitryax dmitryax approved these changes

@pmm-sumo pmm-sumo pmm-sumo approved these changes

Assignees

@pmm-sumo pmm-sumo

Labels
ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tigrannajaryan @pmm-sumo @codeboten @dmitryax