[processor/attributes] Add support to filter on log body #8996
Conversation
atoulme
force-pushed
the
support_attributes_processor_with_log_body
branch
from
1e87874
to
7a8c10c
Compare
There was a problem hiding this comment.
I think example in README.md how to use the log_bodies would be good to have. Also one in testdata
I believe we should a add a positive test case, perhaps basing on TestLogRecord_Matching_True
This change should be mentioned in changelog
@open-telemetry/log-collection-approvers could you take a look as well?
|
Could it support regexes? |
I believe so, since it's using filterset underneath, which can be also configured with regular expression to match |
|
also, kind of related PR: #5680 |
|
@sumo-drosiek your PR looks much better than mine, why didn't it make it? My PR is just about one thing, getting log bodies to be used for the processor. Right now, the processor is useless for logs since it only allows to filter on the name attribute (I actually think looking at the logs the name filters is not working) and that attribute is deprecated. So if that small scope of change is ok and gets us there, please don't mind me and I'll keep plugging away. |
I believe there was some research on using common expression language for OpenTelemetry Collector components in progress back then, which I believe ended up with conclusion that we want to follow with what is now transformprocessor. The latter is still a work in progress, so I think we should be OK with making some small changes/additions to filter/attributes/resource processors as needed (like adding another fields which can be filtered), though I believe that adding another expression language here is too much and we should rather wait until |
|
That sounds about right. This is SlowTel so I'd recommend not expecting quick progress regardless of the component ;) |
|
@pmm-sumo feedback addressed, but no example in README, sorry. I didn't see a good spot for it. |
atoulme
force-pushed
the
support_attributes_processor_with_log_body
branch
from
ce9fc5d
to
088dd03
Compare
| @@ -218,6 +218,10 @@ attributes: | |||
| # This is an optional field. | |||
| log_names: [<item1>, ..., <itemN>] | |||
|
|
|||
| # The log body must match at least one of the items. | |||
| # This is an optional field. | |||
| log_bodies: [<item1>, ..., <itemN>] | |||
There was a problem hiding this comment.
I think it's worth mentioning that only String bodies are matched against here
Co-authored-by: Przemek Maciolek <[email protected]>
Co-authored-by: Dmitrii Anoshin <[email protected]>
jpkrohling
changed the title
Description:
Add support to filter logs based on their body.
Link to tracking Issue:
None
Testing:
Unit tests
Documentation:
Added to README