Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/datadog] Add metrics::summaries::mode setting; deprecate metrics::report_quantiles #8846

Merged
merged 16 commits into from
Apr 25, 2022

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Mar 25, 2022

Description:

  • Add new metrics::summaries::mode setting.
  • Deprecate metrics::report_quantiles in favor of metrics::summaries::mode.

Link to tracking Issue: #8845

Testing: Add unit tests for invalid mode; test manually. The existing unit tests for cumulative_monotonic_mode are enough to check the deprecation system

Documentation: Updated the docs to reflect the new option

@mx-psi mx-psi marked this pull request as ready for review March 31, 2022 14:45
@mx-psi mx-psi requested a review from a team as a code owner March 31, 2022 14:45
@mx-psi mx-psi requested a review from dashpole March 31, 2022 14:45
@jpkrohling
Copy link
Member

Interesting, the conflict I have when checking out this PR is different:

Unmerged paths:
  (use "git restore --staged <file>..." to unstage)
  (use "git add <file>..." to mark resolution)
	both modified:   exporter/datadogexporter/factory_test.go

Right now, GitHub tells me the conflict is at the changelog. @mx-psi, could you please take a look?

@mx-psi
Copy link
Member Author

mx-psi commented Apr 1, 2022

Interesting, the conflict I have when checking out this PR is different:

Unmerged paths:
  (use "git restore --staged <file>..." to unstage)
  (use "git add <file>..." to mark resolution)
	both modified:   exporter/datadogexporter/factory_test.go

Right now, GitHub tells me the conflict is at the changelog. @mx-psi, could you please take a look?

I fixed that on 0817d87, I think your branch was outdated. Anyway, all conflicts fixed now!

Copy link
Contributor

@KSerrania KSerrania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

exporter/datadogexporter/README.md Outdated Show resolved Hide resolved
@mx-psi mx-psi added the ready to merge Code review completed; ready to merge by maintainers label Apr 20, 2022
@mx-psi
Copy link
Member Author

mx-psi commented Apr 25, 2022

@jpkrohling if everything looks good, could this be merged?

@jpkrohling jpkrohling merged commit ab4ed72 into open-telemetry:main Apr 25, 2022
@mx-psi mx-psi deleted the mx-psi/quantiles-mode branch April 25, 2022 15:05
djaglowski pushed a commit to djaglowski/opentelemetry-collector-contrib that referenced this pull request May 10, 2022
…`metrics::report_quantiles` (open-telemetry#8846)

* [exporter/datadog] Add `metrics::summaries::mode` setting; deprecate `metrics::report_quantiles`

* Add changelog entry

* Bump version of deprecation and removal

This won't make it into v0.48.0, so I am bumping to v0.49.0s

* Fix changelog

* Apply suggestions from code review

Co-authored-by: Kylian Serrania <[email protected]>

* Fix changelog after merge

Co-authored-by: Juraci Paixão Kröhling <[email protected]>
Co-authored-by: Kylian Serrania <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants