-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/datadog] Add metrics::summaries::mode
setting; deprecate metrics::report_quantiles
#8846
[exporter/datadog] Add metrics::summaries::mode
setting; deprecate metrics::report_quantiles
#8846
Conversation
…`metrics::report_quantiles`
f7aa853
to
ad4f356
Compare
This won't make it into v0.48.0, so I am bumping to v0.49.0s
Interesting, the conflict I have when checking out this PR is different:
Right now, GitHub tells me the conflict is at the changelog. @mx-psi, could you please take a look? |
I fixed that on 0817d87, I think your branch was outdated. Anyway, all conflicts fixed now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Kylian Serrania <[email protected]>
@jpkrohling if everything looks good, could this be merged? |
…`metrics::report_quantiles` (open-telemetry#8846) * [exporter/datadog] Add `metrics::summaries::mode` setting; deprecate `metrics::report_quantiles` * Add changelog entry * Bump version of deprecation and removal This won't make it into v0.48.0, so I am bumping to v0.49.0s * Fix changelog * Apply suggestions from code review Co-authored-by: Kylian Serrania <[email protected]> * Fix changelog after merge Co-authored-by: Juraci Paixão Kröhling <[email protected]> Co-authored-by: Kylian Serrania <[email protected]>
Description:
metrics::summaries::mode
setting.metrics::report_quantiles
in favor ofmetrics::summaries::mode
.Link to tracking Issue: #8845
Testing: Add unit tests for invalid mode; test manually. The existing unit tests for
cumulative_monotonic_mode
are enough to check the deprecation systemDocumentation: Updated the docs to reflect the new option