Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about exporter reviewers to README.md #776

Merged
merged 3 commits into from
Aug 21, 2020

Conversation

pjanotti
Copy link
Contributor

Helping finding reviewers for exporter changes.

/exporter/alibabacloudlogserviceexporter/ @shabicheng
/exporter/awsxrayexporter/ @kbrockhoff @anuraaga
/exporter/azuremonitorexporter/ @pcwiese
/exporter/carbonexporter/ @pjanotti
/exporter/elasticexporter/ @axw
/exporter/honeycombexporter/ @paulosman @lizthegrey
/exporter/jaegerthrifthttpexporter/ @jpkrohling @pavolloffay
/exporter/kinesisexporter/ @owais
/exporter/lightstepexporter/ @austinlparker @jmacd
/exporter/newrelicexporter/ @MrAlias
/exporter/sapmexporter/ @owais @dmitryax
/exporter/sentryexporter/ @AbhiPrasad
/exporter/signalfxexporter/ @pmcollins @asuresh4
/exporter/splunkhecexporter/ @atoulme
/exporter/stackdriverexporter/ @nilebox @james-bebbington

@pjanotti pjanotti requested a review from a team as a code owner August 20, 2020 00:47
@pjanotti pjanotti self-assigned this Aug 20, 2020
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #776 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #776      +/-   ##
==========================================
+ Coverage   87.80%   87.84%   +0.04%     
==========================================
  Files         217      217              
  Lines       11746    11746              
==========================================
+ Hits        10313    10318       +5     
+ Misses       1086     1082       -4     
+ Partials      347      346       -1     
Flag Coverage Δ
#integration 69.55% <ø> (ø)
#unit 87.65% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
receiver/carbonreceiver/transport/tcp_server.go 67.61% <0.00%> (+1.90%) ⬆️
receiver/prometheusexecreceiver/receiver.go 85.29% <0.00%> (+2.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23dfc78...8ff6b06. Read the comment docs.

@pjanotti
Copy link
Contributor Author

Unfortunately, this won't work as intended recording the info on the README so approvers and maintainers can quickly find the proper alias to add to reviews.

@pjanotti pjanotti changed the title Add code owners to exporters Add info about exporter reviewers to README.md Aug 20, 2020
@axw
Copy link
Contributor

axw commented Aug 21, 2020

Unfortunately, this won't work as intended recording the info on the README so approvers and maintainers can quickly find the proper alias to add to reviews.

Out of curiosity, why won't it work? Because it'll block regular refactoring and go.mod updates?

@pjanotti
Copy link
Contributor Author

Out of curiosity, why won't it work? Because it'll block regular refactoring and go.mod updates?

For CODEOWNERS to work every account listed there would need to have write permissions to the repo.

@pjanotti pjanotti merged commit fd17675 into open-telemetry:master Aug 21, 2020
@pjanotti pjanotti deleted the add-exporter-owners branch August 21, 2020 17:27
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
codeboten pushed a commit that referenced this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants