Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jaeger_thrift in docker-compose example #7243

Merged
merged 3 commits into from
Jan 18, 2022
Merged

Remove jaeger_thrift in docker-compose example #7243

merged 3 commits into from
Jan 18, 2022

Conversation

sincejune
Copy link
Contributor

Description:
Use Jaeger gRPC instead of Thrift in the docker-compose example

Link to tracking Issue:
Closes #7242

Testing:
Tested locally

Documentation:
None

@sincejune sincejune requested a review from a team as a code owner January 18, 2022 16:00
@sincejune
Copy link
Contributor Author

sincejune commented Jan 18, 2022 •
edited
Loading

Add @jpkrohling

jpkrohling
jpkrohling approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have Docker compose here, but could you please provide positive confirmation that you did run this and it worked?

@codeboten codeboten enabled auto-merge (squash) January 18, 2022 18:11
@codeboten codeboten merged commit 6654ba7 into open-telemetry:main Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling approved these changes

@codeboten codeboten codeboten approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan tigrannajaryan is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees

@bogdandrutu bogdandrutu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Jaeger gRPC instead of Thrift in the example
4 participants
@sincejune @jpkrohling @codeboten @bogdandrutu